Skip to content

Allows External fonts to be specified by filename #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

makermelissa
Copy link
Collaborator

Also this work for loading up a font and passing that in like before so it doesn't break anything. :)

@makermelissa makermelissa requested a review from a team December 13, 2019 21:38
@makermelissa
Copy link
Collaborator Author

Could somebody please take a look at this? Thanks.

@ladyada
Copy link
Member

ladyada commented Dec 16, 2019

i didnt test

@makermelissa
Copy link
Collaborator Author

I tested on show_badge(), but didn't yet on show_business_card(). I'll test on that before merging.

@makermelissa
Copy link
Collaborator Author

Tested successfully, but I added a small improvement.

@makermelissa makermelissa merged commit 66c0ff0 into adafruit:master Dec 16, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 17, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.2.0 from 2.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#24 from CedarGroveStudios/master
  > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#21 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 1.0.1 from 0.9.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#14 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#13 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#12 from makermelissa/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants